Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19317 )
Change subject: [thirdparty] build RocksDB without liburing ...................................................................... [thirdparty] build RocksDB without liburing As of 7.7.3 version, RocksDB picks up liburing by default if it's present on the build machine, and it doesn't error out if the library isn't found. Since we don't yet have the liburing in Kudu's thirdparty, that might result in unpredictable run-time dependencies. For now, let's explicitly disable building RocksDB with liburing to have more predictable build outcomes with RocksDB. Probably, at some point it makes sense add liburing to Kudu's thirdparty and re-enable building RocksDB with liburing if performance tests show much better results when using the library. Change-Id: Ia5ac4fb18c90a18f0ae6f96f36888d46d0a4d264 Reviewed-on: http://gerrit.cloudera.org:8080/19317 Tested-by: Kudu Jenkins Reviewed-by: Yingchun Lai <[email protected]> --- M thirdparty/build-definitions.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia5ac4fb18c90a18f0ae6f96f36888d46d0a4d264 Gerrit-Change-Number: 19317 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
