Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19258 )
Change subject: KUDU-3371 [util] add NextOf method for ObjectIdGenerator ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/19258/2/src/kudu/util/oid_generator.cc File src/kudu/util/oid_generator.cc: http://gerrit.cloudera.org:8080/#/c/19258/2/src/kudu/util/oid_generator.cc@68 PS2, Line 68: string next(id); : next[next.size() - 1] += 1; : return next; > The key in rocksdb is designed to combine contianer's id and block's id, an I see, thank you for the explanation. -- To view, visit http://gerrit.cloudera.org:8080/19258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I293baa379e8d64adc4ff93acdb0713aae2731c7d Gerrit-Change-Number: 19258 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 06:59:04 +0000 Gerrit-HasComments: Yes
