Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19323 )
Change subject: KUDU-3413: Add namespace implementation for multi-tenancy ...................................................................... Patch Set 1: (1 comment) Thank you for starting the work on a new feature. I think posting this code is a bit premature before getting some feedback on the design first. Please start with a design document where there is some explanation what problem you are trying to solve and what are the requirements. Providing example use-cases helps as well. For design discussion, using a shared google doc might be a good option. Probably, that should be based on what you posted in the description for KUDU-3413 (using JIRA for design discussion isn't convenient). You could find examples of prior design discussions opened in the dev@ mailist (e.g.: https://lists.apache.org/thread/m7kgms1lngrp5opnftp69rvxmwt90yk2) Thank you! http://gerrit.cloudera.org:8080/#/c/19323/1/src/kudu/fs/fs.proto File src/kudu/fs/fs.proto: http://gerrit.cloudera.org:8080/#/c/19323/1/src/kudu/fs/fs.proto@38 PS1, Line 38: message TenantMetadataPB { : // Tenant name. : optional string tenant_name = 1; : : // Encrypted tenant key used to encrypt/decrypt file keys for this tenant. : optional string tenant_key = 2; : : // Initialization vector for the tenant key. : optional string tenant_key_iv = 3; : : // Tenant key version. : optional string tenant_key_version = 4; : } : : repeated TenantMetadataPB tenants = 3; Is this a compatible change? I'm not sure newer binary would be able to read metadata generated by older versions with this. Do you plan to provide a migration tool for old data as well? -- To view, visit http://gerrit.cloudera.org:8080/19323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23fa349135ba36a25ddc636c1d2a0d9bce45cb4a Gerrit-Change-Number: 19323 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Dec 2022 06:30:49 +0000 Gerrit-HasComments: Yes
