Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19327 )
Change subject: [Tool] Compact metadata file for old versions of Kudu ...................................................................... Patch Set 2: (5 comments) > Patch Set 1: > > (5 comments) http://gerrit.cloudera.org:8080/#/c/19327/1/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: http://gerrit.cloudera.org:8080/#/c/19327/1/src/kudu/tools/tool_action_fs.cc@128 PS1, Line 128: DEFINE_validator(metadata_op_type, &ValidateMetadataOpType); > warning: redundant boolean literal in conditional return statement [readabi Done http://gerrit.cloudera.org:8080/#/c/19327/1/src/kudu/tools/tool_action_fs.cc@160 PS1, Line 160: using std::unordered_map; > warning: using decl 'set' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/19327/1/src/kudu/tools/tool_action_fs.cc@872 PS1, Line 872: RETURN_NOT_OK(env->LockFile(filename, &file_lock)); > warning: parameter 'context' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/19327/1/src/kudu/tools/tool_action_fs.cc@887 PS1, Line 887: // Create a thread pool. > warning: redundant boolean literal in conditional assignment [readability-s Done http://gerrit.cloudera.org:8080/#/c/19327/1/src/kudu/tools/tool_action_fs.cc@913 PS1, Line 913: RETURN_NOT_OK(pool->Submit([container_name, &total_blocks, &total_live_blocks, > warning: redundant get() call on smart pointer [readability-redundant-smart Done -- To view, visit http://gerrit.cloudera.org:8080/19327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id61cb6c88d7a093a8448e2497639f5c5c094efa4 Gerrit-Change-Number: 19327 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Thu, 08 Dec 2022 02:01:44 +0000 Gerrit-HasComments: Yes
