Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/19355 )
Change subject: [tablet] clean up on Tablet::FlushBiggestDMS()
......................................................................
[tablet] clean up on Tablet::FlushBiggestDMS()
I was looking into the code in tablet.{cc,h} related to various
maintenance operations and found there was some room for improvement.
So, this patch updates the code with:
* renaming Tablet::FlushBiggestDMS --> Tablet::FlushBiggestDMSForTests
since that method is called only by tests
* wrapping FlushBiggestDMSForTests into ASSERT_OK in tests
* wrapping maintenance operations into std::unique_ptr
in {Tablet,TabletReplica}::maintenance_ops_ containers instead of
storing raw pointers
* using std::make_shared() instead of std::shared_ptr(new ...)
* using std::move() with std::shared_ptr where appropriate
* fixing unsorted style-related nits
Change-Id: I1760671f32694801e018ac7f5854e3fb95a23876
Reviewed-on: http://gerrit.cloudera.org:8080/19355
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <[email protected]>
---
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/tablet_history_gc-itest.cc
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/tablet_server-test.cc
12 files changed, 104 insertions(+), 106 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1760671f32694801e018ac7f5854e3fb95a23876
Gerrit-Change-Number: 19355
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
