Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19370 )
Change subject: [tools] Support to dump rowset primary key bounds and in readable format ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19370/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19370/1//COMMIT_MSG@14 PS1, Line 14: by setting flag --dump_primary_key_bounds_only. Could you explain in which situation it is need to dump primary key bound only? http://gerrit.cloudera.org:8080/#/c/19370/1/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19370/1/src/kudu/tools/tool_action_local_replica.cc@792 PS1, Line 792: string DumpRow(const Schema& key_proj, const RowBlockRow& row, faststring* key) { "faststring* key" is not need to be posted from outside. How about defining a local faststring? http://gerrit.cloudera.org:8080/#/c/19370/1/src/kudu/tools/tool_action_local_replica.cc@1033 PS1, Line 1033: if (FLAGS_dump_primary_key_bounds_only) { Why this code outside of the loop: Line1018? -- To view, visit http://gerrit.cloudera.org:8080/19370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9757104f96648c3c83b931369f0e377d8dc2079a Gerrit-Change-Number: 19370 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 01:19:10 +0000 Gerrit-HasComments: Yes
