Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18946 )
Change subject: [Tools] Rebalance data among different disks ...................................................................... Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/fs/file_block_manager.cc@696 PS6, Line 696: Status FileBlockManager::MigrateBlock(CreateBlockOptions opts, > warning: parameter 'opts' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/fs/file_block_manager.cc@697 PS6, Line 697: const BlockId& block_id) { > warning: parameter 'block_id' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/fs/file_block_manager.cc@701 PS6, Line 701: Status FileBlockManager::GetBlockDirIdx(const BlockId& block_id, int* dir) { > warning: parameter 'block_id' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/fs/log_block_manager.cc@2723 PS6, Line 2723: LogBlockRefPtr LogBlockManager::CreateLogBlock( > warning: method 'CreateLogBlock' can be made static [readability-convert-me Done http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/tserver/tablet_server-test.cc@3858 PS6, Line 3858: virtual void SetUp() OVERRIDE { > warning: 'virtual' is redundant since the function is already declared 'ove Done http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/tserver/tablet_service.h File src/kudu/tserver/tablet_service.h: http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/tserver/tablet_service.h@97 PS6, Line 97: class DiskRebalanceResponsePB > error: expected ';' after class [clang-diagnostic-error] Done http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/tserver/tablet_service.h@243 PS6, Line 243: void DiskRebalance(const DiskRebalanceRequestPB* req, > warning: annotate this function with 'override' or (rarely) 'final' [modern Done http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/18946/6/src/kudu/tserver/tablet_service.cc@1455 PS6, Line 1455: void TabletServiceAdminImpl::DiskRebalance(const DiskRebalanceRequestPB* req, > warning: parameter 'req' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/18946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I368d718e032bec9516cb165ab65c7ea3be083ba4 Gerrit-Change-Number: 18946 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 06:18:28 +0000 Gerrit-HasComments: Yes
