Yifan Zhang has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19389 )

Change subject: [server] add 'memory_usage' metric for server
......................................................................

[server] add 'memory_usage' metric for server

Recently, from a post-mortem analysis of diagnostic logs created by
kudu-tserver process, I realized it would be useful to know current
memory consumption along with other metrics and stack traces of all
the threads run by the process.

I didn't add any tests for the newly introduced metric, but I manually
verified that both kudu-master and kudu-tserver processes properly
reported current memory usage among other server metrics at the
"/metrics" HTTP endpoint.  The newly introduced metric was also present
in the diagnostic log files, and it was possible to extract the readings
of the metric by running the following kudu CLI command on the
corresponding files:

  kudu diagnose parse_metrics --simple_metrics=server.memory_usage

Change-Id: If066be928bd1c7c3f37c875937ae8802dd8fcd33
Reviewed-on: http://gerrit.cloudera.org:8080/19389
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <[email protected]>
---
M src/kudu/server/server_base.cc
1 file changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yifan Zhang: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/19389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If066be928bd1c7c3f37c875937ae8802dd8fcd33
Gerrit-Change-Number: 19389
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <[email protected]>

Reply via email to