Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19357 )
Change subject: [tools] Add 'kudu local_replica tmeta delete_rowsets' to delete rowsets from tablet ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/19357/8/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/19357/8/src/kudu/tablet/tablet_metadata.cc@63 PS8, Line 63: or and http://gerrit.cloudera.org:8080/#/c/19357/8/src/kudu/tablet/tablet_metadata.cc@64 PS8, Line 64: for in http://gerrit.cloudera.org:8080/#/c/19357/8/src/kudu/tools/tool_main.cc File src/kudu/tools/tool_main.cc: http://gerrit.cloudera.org:8080/#/c/19357/8/src/kudu/tools/tool_main.cc@260 PS8, Line 260: CHECK_NE("", google::SetCommandLineOptionWithMode( > Reset the default value before calling gflags::ParseCommandLineNonHelpFlags Ah, indeed -- it seems I misguided you on this topic, and the result is many failed tests. I think this should be done a different way in the context of the CLI tool: see https://github.com/apache/kudu/blob/986f1a0cd0427e548a8bff7ccc53b626335ebc57/src/kudu/tools/tool_action_master.cc#L815 for example. I guess we need to have similar setting for "enable_tablet_orphaned_block_deletion" at https://gerrit.cloudera.org/#/c/19357/8/src/kudu/tools/tool_action_local_replica.cc@1285 -- To view, visit http://gerrit.cloudera.org:8080/19357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2cf9035babf4c3af4c238cebe8dcecd2c65848f Gerrit-Change-Number: 19357 Gerrit-PatchSet: 8 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 05 Jan 2023 19:56:22 +0000 Gerrit-HasComments: Yes
