Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19406 )
Change subject: [refactor] fix some tidy warnings on fs module ...................................................................... [refactor] fix some tidy warnings on fs module There are no functional changes in this patch, but only some refactors including: 1. remove the default arguments from BlockManager::Open to mute warnings like: warning: default arguments on virtual or override methods are prohibited [google-default-arguments] 2. add 'override' and remove 'virtual' for derived classes destructors of BlockManager to mute warnings like: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override] Change-Id: I5fc6d78d8eb1468988fe53e64b2fcaed59652ffe Reviewed-on: http://gerrit.cloudera.org:8080/19406 Reviewed-by: Yuqi Du <[email protected]> Tested-by: Yingchun Lai <[email protected]> Reviewed-by: Wang Xixu <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> --- M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/file_block_manager.h M src/kudu/fs/fs_manager.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.h 7 files changed, 21 insertions(+), 19 deletions(-) Approvals: Yuqi Du: Looks good to me, but someone else must approve Yingchun Lai: Verified Wang Xixu: Looks good to me, but someone else must approve Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5fc6d78d8eb1468988fe53e64b2fcaed59652ffe Gerrit-Change-Number: 19406 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]>
