Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/19272/9/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/19272/9/src/kudu/client/schema.cc@1031 PS9, Line 1031: indexes->resize(num_key_columns()); > I guess Alexey's suggestion is to change the return type as "const string&" Ah okay, sorry I misunderstood it. Anyway the linter was complaining that std::string shouldn't be used for global/static string constants. C style is preferred. I changed it to 'const char* const'. http://gerrit.cloudera.org:8080/#/c/19272/10/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/19272/10/src/kudu/common/schema.cc@639 PS10, Line 639: return AddColumn(ColumnSchema(name, type, is_nullable, is_immutable, : is_auto_incrementing, read_default, write_default), false); : } : : Status SchemaBuilder::RemoveColumn(const string& name) { : unordered_set<string>::const_iterator it_names = col_names_.find(name); : if (it_names == col_names_.end()) { : return Status::NotFound("The specified column does not exist", name); : } : : col_names_.erase(it_names); : f > Do we still need these checking? Good catch, I removed these as well. -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 13 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 13 Jan 2023 17:01:13 +0000 Gerrit-HasComments: Yes
