Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19010 )

Change subject: Busy loop is proposed for ppc64le to implement PauseCPU()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19010/1/src/kudu/gutil/atomicops-internals-powerpc.h
File src/kudu/gutil/atomicops-internals-powerpc.h:

http://gerrit.cloudera.org:8080/#/c/19010/1/src/kudu/gutil/atomicops-internals-powerpc.h@50
PS1, Line 50: inline void PauseCPU() {
            : }
Just for posterity: per 
https://stackoverflow.com/questions/5425506/equivalent-of-x86-pause-instruction-for-ppc
 , it might be possible to use some asm instructions here instead, like 
HMT_vert_low():

#define HMT_very_low()   asm volatile("or 31,31,31   # very low priority")

Unfortunately, I have no access to a ppc64le machine to verify.



--
To view, visit http://gerrit.cloudera.org:8080/19010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5ea633e91e09d102f68639d0ec43792610b58d2
Gerrit-Change-Number: 19010
Gerrit-PatchSet: 1
Gerrit-Owner: harinreddy <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 14 Jan 2023 01:57:44 +0000
Gerrit-HasComments: Yes

Reply via email to