Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18472 )
Change subject: jwt: determine discovery endpoint from token ...................................................................... Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/18472/10/src/kudu/util/jwt-util.h File src/kudu/util/jwt-util.h: http://gerrit.cloudera.org:8080/#/c/18472/10/src/kudu/util/jwt-util.h@120 PS10, Line 120: explicit PerAccountKeyBasedJwtVerifier(std::string jwks_uri) nit: add a blank line after each declaration for readability http://gerrit.cloudera.org:8080/#/c/18472/10/src/kudu/util/jwt-util.h@131 PS10, Line 131: // marked as mutable so that PerAccountKeyBasedJwtVerifier::JWTHelperForToken is able to emplace nit: capitalize the first letter and add a period at the end of the sentence http://gerrit.cloudera.org:8080/#/c/18472/10/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18472/10/src/kudu/util/jwt-util.cc@952 PS10, Line 952: } nit: add a blank line after each closing curly brace http://gerrit.cloudera.org:8080/#/c/18472/10/src/kudu/util/jwt-util.cc@960 PS10, Line 960: if (unique_helper) { nit: add a blank line above this http://gerrit.cloudera.org:8080/#/c/18472/10/src/kudu/util/jwt-util.cc@982 PS10, Line 982: #define RETURN_INVALID_IF(stmt, msg) \ Should this be #undef-ed when it's not used anymore? http://gerrit.cloudera.org:8080/#/c/18472/10/src/kudu/util/jwt-util.cc@994 PS10, Line 994: // TODO(awong): this implementation expects there to be a small number of nit: maybe change the todo to yours? -- To view, visit http://gerrit.cloudera.org:8080/18472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I970bcc6d894c0206160196418d549b71c35ac973 Gerrit-Change-Number: 18472 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 16 Jan 2023 20:23:08 +0000 Gerrit-HasComments: Yes
