Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19418 )
Change subject: [examples] Make java-example up-to-date ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/19418/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19418/2//COMMIT_MSG@11 PS2, Line 11: Osx nit: since some 10.x version they started officially calling it macOS $ sw_vers ProductName: macOS ProductVersion: 11.7 BuildVersion: 20G817 http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc File examples/java/java-example/README.adoc: http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc@39 PS2, Line 39: This means that the exact version and architecture jar file can not : be found in the maven repo It means the maven repository does not contain a JAR file with the exact architecture and version. http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc@40 PS2, Line 40: be worked around by I guess here the essence of the workaround should be outlined, i.e. building the required JAR locally and running with local the local repository? The required practical steps could be presented right below in a form of bulleted/numbered list or something like that, but having them in a sentence, separated by commas is also OK. http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc@41 PS2, Line 41: dir directory http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/README.adoc@41 PS2, Line 41: set setting http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/pom.xml File examples/java/java-example/pom.xml: http://gerrit.cloudera.org:8080/#/c/19418/2/examples/java/java-example/pom.xml@31 PS2, Line 31: 1.16.0 nit: you could separate this into its own changelist since the up-to-date version in the examples and arch-related workaround for Apple M1 chips are orthogonal. -- To view, visit http://gerrit.cloudera.org:8080/19418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eaa4799287adb2b8c90f62e9d90f7f7105de1 Gerrit-Change-Number: 19418 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Wed, 18 Jan 2023 04:56:05 +0000 Gerrit-HasComments: Yes
