Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )
Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes ...................................................................... Patch Set 4: Verified+1 (6 comments) +1 for adding a link to a screenshot of the maintenance manager page, as suggested by Yifan http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@11 PS4, Line 11: no the information no such information http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@11 PS4, Line 11: showed shown http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13 PS4, Line 13: protobuf file the protobuf file http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13 PS4, Line 13: show it at web pages ... updates the embedded web server to show the retained bytes for a maintenance operation http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13 PS4, Line 13: variable field http://gerrit.cloudera.org:8080/#/c/19407/4/src/kudu/integration-tests/webserver-stress-itest.cc File src/kudu/integration-tests/webserver-stress-itest.cc: http://gerrit.cloudera.org:8080/#/c/19407/4/src/kudu/integration-tests/webserver-stress-itest.cc@101 PS4, Line 101: #ifdef __linux__ Would be great to add a comment to explain why having this extra check under this macro. -- To view, visit http://gerrit.cloudera.org:8080/19407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e Gerrit-Change-Number: 19407 Gerrit-PatchSet: 4 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 18 Jan 2023 05:16:18 +0000 Gerrit-HasComments: Yes
