Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19411 )
Change subject: [tools] add --tables flag to 'local_replica delete' ...................................................................... Patch Set 6: Code-Review-1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19411/6/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19411/6/src/kudu/tools/tool_action_local_replica.cc@801 PS6, Line 801: npos I think this condition at least needs some rework.I tried: command: ./bin/kudu local_replica delete 'nonexistent' -fs_data_dirs=$PWD/tserver-1/data -fs_wal_dir=$PWD/tserver-1/wal --clean_unsafe --ignore_nonexistent=false result: Not found: specified tablet id does not exist or does not match table name patterns specified in --tables flag. command: ./bin/kudu local_replica delete 'nonexistent*' -fs_data_dirs=$PWD/tserver-1/data -fs_wal_dir=$PWD/tserver-1/wal --clean_unsafe --ignore_nonexistent=false result: I20230118 15:49:01.422336 1808955 tool_action_local_replica.cc:809] deleting 0 tablet replicas. I expected the same behaviour and error message if I give some pattern that maps to no tablets even with or without the "*". -- To view, visit http://gerrit.cloudera.org:8080/19411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329 Gerrit-Change-Number: 19411 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Jan 2023 15:27:17 +0000 Gerrit-HasComments: Yes
