Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19271 )
Change subject: KUDU-3423 Add support for Ranger KMS HA ...................................................................... Patch Set 6: (2 comments) Sorry for the delay Alexey, replied to your comments. http://gerrit.cloudera.org:8080/#/c/19271/5/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/19271/5/src/kudu/fs/fs_manager.cc@149 PS5, Line 149: if (FLAGS_ranger_kms_url.empty() || > This line seems to be too long Done http://gerrit.cloudera.org:8080/#/c/19271/4/src/kudu/util/curl_util.h File src/kudu/util/curl_util.h: PS4: > Yup, we do have some scenarios using the embedded webserver in webserver-te Yea that makes sense. OTOH it feels weird to add a test case to webserver-test that is testing curl itself instead of the webserver. -- To view, visit http://gerrit.cloudera.org:8080/19271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibef941ed20eda1f4e624c2c7e16ca7955af570d8 Gerrit-Change-Number: 19271 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 27 Jan 2023 15:36:15 +0000 Gerrit-HasComments: Yes
