Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19457 )
Change subject: [docs] Document data at rest encryption ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc File docs/security.adoc: http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@488 PS3, Line 488: Kudu allows all communications among servers and between clients and servers : to be encrypted with TLS. nit: maybe, add an extra sentence to this summary to mention that Kudu also supports data-at-rest encryption? http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@508 PS3, Line 508: phsyical physical http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@510 PS3, Line 510: a the This should be either 'a' or 'the'. Probably, 'the' is the better choice as I can see from the context. http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@514 PS3, Line 514: Data at rest encryption can be enabled nit: to match the corresponding sentence from the 'Data in Transit' section, maybe change this to 'Encryption at rest can be enabled ...' http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@601 PS3, Line 601: #------------------------ nit: I guess the readers would appreciate to have a small commented explanation for the example below, similar to the text blurb for the coarse-grain authorization example above. If adding that, maybe it would be more natural to have example cluster name and example URL for Ranger KMS instead of placeholders. -- To view, visit http://gerrit.cloudera.org:8080/19457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49 Gerrit-Change-Number: 19457 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 30 Jan 2023 18:39:00 +0000 Gerrit-HasComments: Yes
