Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19463 )
Change subject: [tserver] keep the order of appling ops the same as raft wal ...................................................................... Patch Set 1: (11 comments) Is this specific issue of out-of-order ops seen in any environment? It would really help if you could also capture one liners about following points: 1. How can out-of-order ops happen given the current concurrent thread-pool implementation? 2. What would be the repercussions if we have these out-of-order ops? Any corruption? 3. Any performance impact due to this serialisation? http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@7 PS1, Line 7: keep the order of appling ops the same as raft wal nit: Keep the order of applying the ops same as raft WAL. http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@10 PS1, Line 10: Apply nit: Applying http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@10 PS1, Line 10: be the same nit: be same http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@9 PS1, Line 9: is an total order : in server-side nit: is in total order on server side http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@11 PS1, Line 11: But now apply ops by 'apply_pool->Submit' that's a concurrent threadpool, nit: Currently, applying ops using "apply_pool_->Submit" (i.e. concurrent thread-pool) http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@12 PS1, Line 12: some ops out nit: some ops to go out http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@29 PS1, Line 29: would valid nit: would become valid http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@29 PS1, Line 29: nit: extra whitespace http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@29 PS1, Line 29: not our expected nit: not expected http://gerrit.cloudera.org:8080/#/c/19463/1//COMMIT_MSG@30 PS1, Line 30: would nit: could http://gerrit.cloudera.org:8080/#/c/19463/1/src/kudu/tablet/tablet_replica.h File src/kudu/tablet/tablet_replica.h: http://gerrit.cloudera.org:8080/#/c/19463/1/src/kudu/tablet/tablet_replica.h@604 PS1, Line 604: seral nit: Serial -- To view, visit http://gerrit.cloudera.org:8080/19463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id040122ab9473d1a8b03a2a1e751454a32b89d87 Gerrit-Change-Number: 19463 Gerrit-PatchSet: 1 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 31 Jan 2023 13:27:02 +0000 Gerrit-HasComments: Yes
