Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18472 )
Change subject: jwt: determine discovery endpoint from token ...................................................................... Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/18472/14/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18472/14/src/kudu/util/jwt-util-test.cc@1073 PS14, Line 1073: } > Ah, sure. I meant: what happens if, say, an assertion for VerifyToken() tr Thanks for the clarification! I did some manual testing, by injecting assertions to random iterations that would definitely fail and those did not trigger the expected failures. I've since changed those assertions to CHECKs, which work as expected. http://gerrit.cloudera.org:8080/#/c/18472/20/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18472/20/src/kudu/util/jwt-util.cc@960 PS20, Line 960: > Is it really necessary to hold this lock even after finding the element in A lock here is necessary as there might be a lookup here while another thread might be writing at the same time, but I restructured the code a bit so the same lock is used, but separately in their own scope. -- To view, visit http://gerrit.cloudera.org:8080/18472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I970bcc6d894c0206160196418d549b71c35ac973 Gerrit-Change-Number: 18472 Gerrit-PatchSet: 21 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 01 Feb 2023 15:38:39 +0000 Gerrit-HasComments: Yes
