Yuqi Du has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19493 )

Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19493/2/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/19493/2/src/kudu/tools/tool_action_table.cc@361
PS2, Line 361:       if (tables_info_pb.tables().size() > 0)
what about:

if (!tables_info_pb.tables().empty()) {
   cout << ToPrettyFormat(tables_info_pb) << endl;
}


or


if (iequals(FLAGS_list_table_output_format, "pretty") && 
!tables_info_pb.tables().empty()) {
    cout << ToPrettyFormat(tables_info_pb) << endl;
}



--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Thu, 16 Feb 2023 07:07:26 +0000
Gerrit-HasComments: Yes

Reply via email to