Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19514 )
Change subject: [thirdparty] skip build/generation of LLVM benchmarks ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19514/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19514/1//COMMIT_MSG@9 PS1, Line 9: benchmarsk nit: benchmarks http://gerrit.cloudera.org:8080/#/c/19514/1//COMMIT_MSG@9 PS1, Line 9: turns off generation and build of LLVM Just curious - how do you decide whether this is a candidate for which generation and build can be turned off? http://gerrit.cloudera.org:8080/#/c/19514/1//COMMIT_MSG@13 PS1, Line 13: building LLVM on Ubuntu 22.04 I started a fresh build (without setting CPATH). I was able to build thirdparty successfully but kudu release build failed with following error: +++ [ 34%] Generating precompiled.ll kudu/src/kudu/codegen/precompiled.cc:36:10: fatal error: 'cstdint' file not found #include <cstdint> ^~~~~~~~~ 1 error generated. make[2]: *** [src/kudu/codegen/CMakeFiles/codegen.dir/build.make:85: src/kudu/codegen/precompiled.ll] Error 1 make[1]: *** [CMakeFiles/Makefile2:4672: src/kudu/codegen/CMakeFiles/codegen.dir/all] Error 2 +++ With this patch, were you able to build complete kudu source on Ubuntu 22.04? http://gerrit.cloudera.org:8080/#/c/19514/1//COMMIT_MSG@13 PS1, Line 13: without patching : the LLVM code itself It seems they have fixed this in later releases of llvm but not in this version: https://reviews.llvm.org/rGb498303066a63a203d24f739b2d2e0e56dca70d1 Would it make sense to upgrade the version of third-party source within kudu repo? -- To view, visit http://gerrit.cloudera.org:8080/19514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67592101c5e105b8a4b36fc231b0e67e4585fb0b Gerrit-Change-Number: 19514 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 21 Feb 2023 11:15:01 +0000 Gerrit-HasComments: Yes
