Hello Yingchun Lai,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19576
to review the following change.
Change subject: [tools] exit gracefully on errors during table copying
......................................................................
[tools] exit gracefully on errors during table copying
Prior to this patch, an error to write a batch of rows into the
destination table would lead to a crash while running `kudu table copy`
CLI tool. In addition, the information on errors would not be printed
because CheckPendingErrors() was called before Session::Flush().
This patch updates addresses these issues:
* no crashes for non-OK status within TableScanner::CopyTask()
* information on errors encountered during Session::Flush()
is printed into the output stream
This is a follow-up to 28f8e972fcd042a26a502cbb1f1102c487c9398d.
Change-Id: I90dc29b5a3fb8334ec1f54425b84d13faeb19cd5
Reviewed-on: http://gerrit.cloudera.org:8080/19575
Reviewed-by: Yingchun Lai <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
(cherry picked from commit 8a58c5838ec634146a0af46cdb47d4db404aef0a)
---
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/table_scanner.h
2 files changed, 50 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/19576/1
--
To view, visit http://gerrit.cloudera.org:8080/19576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90dc29b5a3fb8334ec1f54425b84d13faeb19cd5
Gerrit-Change-Number: 19576
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
