Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04 ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt File src/kudu/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt@111 PS1, Line 111: The relevant part of the output looks like the following: nit: Maybe you could also point that the output is from Ubuntu 22.04. And similar looking output would be on other flavours as well. http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt@133 PS1, Line 133: Use only the first two include paths Is there a remote chance that first paths are not the ones that we are interested in? I mean is it possible to have an output with include directories in different order ? e.g. something like this: +++ # /usr/include # /usr/local/include # /usr/include/x86_64-linux-gnu # /usr/include/c++/11 # /usr/include/x86_64-linux-gnu/c++/11 # /usr/include/c++/11/backward # /usr/lib/gcc/x86_64-linux-gnu/11/include +++ In such a case, wouldn't this assumption fail? http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt@145 PS1, Line 145: PREFIXED_IR_INCLUDES Not a comment: This looks like a better idea. Appending include directories to PREFIXED_IR_INCLUDES is certainly a cleaner approach than setting the path in include_directories. -- To view, visit http://gerrit.cloudera.org:8080/19582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982 Gerrit-Change-Number: 19582 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 06 Mar 2023 10:31:46 +0000 Gerrit-HasComments: Yes
