Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: [KUDU-3452] Create tablet without enough healthy tservers ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19571/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/2/src/kudu/master/catalog_manager.cc@5930 PS2, Line 5930: master_->ts_manager()->GetDescriptorsAvailableForPlacement(&ts_descs); > Why move the statement from outer to inner loop? I infer that at a unsteady Why move the statement from outer to inner loop? It used healthy tablet servers totally before. But now the case is different. For example, there are 3 tablet servers, one is unhealthy. Some tablet defined three-replicas, some defined two-replicas. The case is different for different tablets. Therefore, the logic is: firstly, try to use the healthy tablet servers, if it is not enough, try to use unhealthy tablet servers. -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 10 Mar 2023 06:01:54 +0000 Gerrit-HasComments: Yes
