Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19615 )
Change subject: KUDU-3448 Plumbing for encrypting key material ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19615/3/src/kudu/security/crypto.cc File src/kudu/security/crypto.cc: http://gerrit.cloudera.org:8080/#/c/19615/3/src/kudu/security/crypto.cc@116 PS3, Line 116: RuntimeError(GetOpenSSLErrors()) nit: maybe, add some extra information to OpenSSL error messages (they are usually quite cryptic), something like Substitute("$0: error importing encrypted RSA private key", GetOpenSSLErrors()) ? -- To view, visit http://gerrit.cloudera.org:8080/19615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24c5ac8ea0f9a4cab0f35ecccb1b7b00f3acefa8 Gerrit-Change-Number: 19615 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Tue, 14 Mar 2023 07:39:45 +0000 Gerrit-HasComments: Yes
