Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19616 )
Change subject: KUDU-3448 Add support for encrypting IPKI keys ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19616/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19616/4/src/kudu/master/catalog_manager.cc@1360 PS4, Line 1360: RETURN_NOT_OK_PREPEND(security::GetPasswordFromShellCommand( : FLAGS_ipki_private_key_password_cmd, password), : "could not get IPKI private key password from configured command"); : return Status::OK(); : } : )); : } > My concern here is that PasswordCallback might return an empty string, just Good idea, thanks for the suggestion. Changed it. -- To view, visit http://gerrit.cloudera.org:8080/19616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71f2ec856f018d56efbf6901039eed2676fcbe23 Gerrit-Change-Number: 19616 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Tue, 21 Mar 2023 20:47:45 +0000 Gerrit-HasComments: Yes
