Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@101 PS5, Line 101: TabletShower > One of the advantages of using frined class v.s friend function is the clas IMO, creating nonsensical classes to justify some 'too long signature' is a much worse code smell. Maybe, we should then switch to just enumerating all the method names, naming them to be f_001(), ..., f_100(), etc. to shorten their signatures? The same for the names of types, parameters, and variables. Or, an even brighter idea would be creating a miriad of classes, each with a single method named DoIt(). Would you consider that to be a better code, Yingchun Lai? :) -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 22 Mar 2023 20:47:19 +0000 Gerrit-HasComments: Yes
