Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 )
Change subject: [GC] gc ancient, fully deleted rowsets without live row count ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19670/2/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: http://gerrit.cloudera.org:8080/#/c/19670/2/src/kudu/tablet/delta_tracker.h@290 PS2, Line 290: int64_t CountDeletedRowsInRedos() const; nit: leave a blank line. And add some comments for the new added function. http://gerrit.cloudera.org:8080/#/c/19670/2/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: http://gerrit.cloudera.org:8080/#/c/19670/2/src/kudu/tablet/diskrowset.cc@753 PS2, Line 753: CountLiveRowsWithoutLiveRowCount Could you please add some tests for it? http://gerrit.cloudera.org:8080/#/c/19670/2/src/kudu/tablet/tablet_history_gc-test.cc File src/kudu/tablet/tablet_history_gc-test.cc: http://gerrit.cloudera.org:8080/#/c/19670/2/src/kudu/tablet/tablet_history_gc-test.cc@127 PS2, Line 127: ASSERT_EQ(metrics->deleted_rowset_gc_duration->TotalCount(), orig_count); nit: ASSERT_EQ(orig_count, metrics->deleted_rowset_gc_duration->TotalCount()); Where the first parameter is the *expected* value and the second is *actual* value. -- To view, visit http://gerrit.cloudera.org:8080/19670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdff107b8b07cbd56f47f296a93f4bcfbf56b41 Gerrit-Change-Number: 19670 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 31 Mar 2023 16:18:53 +0000 Gerrit-HasComments: Yes
