Hello Yuqi Du, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19673
to review the following change.
Change subject: KUDU-3437 Set default block_cache_metrics_policy to reset
......................................................................
KUDU-3437 Set default block_cache_metrics_policy to reset
If the master has empty local directories and connects to an existing
cluster, it executes Master::Init twice, which executes
StartInstrumentation twice, which is only allowed if it's a test or the
policy is to reset the existing CacheMetrics. According to documentation
ExistingMetricsPolicy::kKeep should only be used during tests, so the
default value is set to kReset which fixes the original issue.
Change-Id: Idc32d7ab02201382debcbe36311579550353bf71
Reviewed-on: http://gerrit.cloudera.org:8080/19585
Tested-by: Kudu Jenkins
Reviewed-by: Yuqi Du <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
(cherry picked from commit e07c941aa6622efb758283cb2a583d0b90deb830)
---
M src/kudu/master/master_options.cc
M src/kudu/master/mini_master.cc
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/19673/1
--
To view, visit http://gerrit.cloudera.org:8080/19673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc32d7ab02201382debcbe36311579550353bf71
Gerrit-Change-Number: 19673
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Reviewer: Ádám Bakai <[email protected]>
