Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 )
Change subject: [multi-tenancy] KUDU-3413 update server key for multi-tenancy ...................................................................... Patch Set 3: (2 comments) Thank you for working on this. Before I proceed with rest of the review, I wanted to understand a few things that would help me understand the code change better. It would really help if you could enlist the step-wise approach you are planning to take for complete implementation. http://gerrit.cloudera.org:8080/#/c/19622/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19622/3//COMMIT_MSG@14 PS3, Line 14: I replaced the server key with the : tenant key, which belongs to the default tenant. Although mapping a node to a single tenant at first may be ok, how would that expand further when multiple tenant scenario is at play? IIUC server key is per node and tenants will have many-to-one relationships with a node. I am just trying to understand the step-wise approach you are planning to take to implement this feature. http://gerrit.cloudera.org:8080/#/c/19622/3/src/kudu/fs/fs.proto File src/kudu/fs/fs.proto: http://gerrit.cloudera.org:8080/#/c/19622/3/src/kudu/fs/fs.proto@59 PS3, Line 59: tenant_name Do you think we need to have a way to make tenants uniquely identifiable? Maybe a uuid specifically for tenants. -- To view, visit http://gerrit.cloudera.org:8080/19622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e450d73940eb1dbaac6f905a46d6ccd084f15cf Gerrit-Change-Number: 19622 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 04 Apr 2023 15:02:02 +0000 Gerrit-HasComments: Yes
