Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18473 )
Change subject: jwt: introduce MiniOidc ...................................................................... Patch Set 20: > Hi! Shall we also cherry-pick the new jwt related commits into > branch-1.17.x? It's a good question, Yingchun! Zoltan Chovan, who owns JWT-related work as of now, might chime in with the assessment on how long it might take to have end-to-end JWT authentication woking in Kudu applicaitons, and whether it's realistic to get it done any soon to be included into Kudu 1.17.0 release. Below is what I think of it. I guess it wouldn't hurt cherry-picking those jwt-related commits into 1.17.x branch, but I'm not sure we will have JWT authentication working end-to-end in 1.17.x even if cherry-picking those patches. The JWT support for Java client isn't yet implemented, and so far not much has been done from the usability perspective to allow a Kudu C++ application using a JWT for authentication. There is KuduClientBuilder::import_authentication_credentials() in current Kudu client C++ API, but it doesn't accept a JWT as-is. With that, if you think that current set of JWT-related patches might be useful to people as-is even if the functionality isn't ready for end-to-end usage in Kudu client applications yet, perhaps it makes sense to cherry-pick them. Otherwise, even with the over-extended timeline for 1.17.0 release, I'd think it's more realistic to plan on getting usable JWT authentication support only in 1.18.0 or later Kudu releases. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/18473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e9b3bcd0946adbe4642a19c5ef1124e39632c6 Gerrit-Change-Number: 18473 Gerrit-PatchSet: 20 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 05 Apr 2023 19:02:39 +0000 Gerrit-HasComments: No
