Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18477 )
Change subject: jwt: Java client usage of JWTs ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/18477/6/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/18477/6/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@273 PS6, Line 273: // TODO(awong): also guard this on the presence of certs. nit: change name to zchovan. http://gerrit.cloudera.org:8080/#/c/18477/6/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java File java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java: http://gerrit.cloudera.org:8080/#/c/18477/6/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java@362 PS6, Line 362: public synchronized void setJsonWebToken(JwtRawPB jwt) { nit: add comment http://gerrit.cloudera.org:8080/#/c/18477/6/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java File java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/18477/6/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java@120 PS6, Line 120: @Test //(timeout = 50000) nit: add timeout back -- To view, visit http://gerrit.cloudera.org:8080/18477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id02dcd7ee57a838f4763500e78053e21aac21c09 Gerrit-Change-Number: 18477 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 13:52:36 +0000 Gerrit-HasComments: Yes
