Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19698 )
Change subject: [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/19698/5/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19698/5/src/kudu/tools/kudu-tool-test.cc@2842 PS5, Line 2842: : nit: probably, it makes sense to keep this as in other lines with not matching "Auto Incrementing Counter" pattern (e.g., lines 2806, 2818, 2830) http://gerrit.cloudera.org:8080/#/c/19698/5/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/19698/5/src/kudu/tools/tool_action_common.cc@352 PS5, Line 352: int64_t auto_incrementing_counter = readability nit: could you add a comment that `auto_incrementing_counter` is used as in-out argument for DecodeOperations() call below? -- To view, visit http://gerrit.cloudera.org:8080/19698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e807aaef48683ec7c5317eecdedf8e6e15950e2 Gerrit-Change-Number: 19698 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 18 Apr 2023 02:10:24 +0000 Gerrit-HasComments: Yes
