Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19769 )
Change subject: [jwt] Fix flaky jwt tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19769/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19769/1//COMMIT_MSG@14 PS1, Line 14: --gtest_filter='*Jwt*' --stress_cpu_threads=32 This doesn't loop the test, just starts a bunch of threads that burn CPU. http://gerrit.cloudera.org:8080/#/c/19769/1/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/19769/1/src/kudu/integration-tests/security-itest.cc@526 PS1, Line 526: const uint64_t kLifetimeMs = 5000; Why is the lifetime so low? Isn't it possible that on a slower machine it would take >5s under heavy load? JWT tokens should be short-lived, but a few minutes is totally fine. -- To view, visit http://gerrit.cloudera.org:8080/19769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I049ecd2330c6aca59bf2edc96af8a0866fd869d4 Gerrit-Change-Number: 19769 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 19 Apr 2023 15:02:35 +0000 Gerrit-HasComments: Yes
