Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19783
Change subject: [util] use include guard macro in int128.h header ...................................................................... [util] use include guard macro in int128.h header Even if '#pragma once' is supported by the vast majority of modern compilers, it is a non-standard one [1]. The src/kudu/util/int128.h file is included into other header files of the C++ Kudu client API, which is supposed to be C++98 compliant. Since other header files in the C++ client API are using include guard macros, let's use the same technique for int128.h as well. Doing so addresses a warning produced by the CLANG when running client_examples_test.sh, while a standalone compilation is done on the kudu/util/int128.h file: #pragma once in main file [-Wpragma-once-outside-header] [1] https://en.cppreference.com/w/cpp/preprocessor/impl Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4 --- M src/kudu/util/int128.h 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/19783/1 -- To view, visit http://gerrit.cloudera.org:8080/19783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4 Gerrit-Change-Number: 19783 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]>
