Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19764 )
Change subject: [tablet] KUDU-3342 Add an implementation of the block cache on HBW ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/19764/16//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19764/16//COMMIT_MSG@13 PS16, Line 13: wil nit: will http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/cfile/block_cache.cc File src/kudu/cfile/block_cache.cc: http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/cfile/block_cache.cc@58 PS16, Line 58: To use 'NVM' or 'HBW', libmemkind 1.8.0 or newer It seems this library is not a system library, so it may be not present at some compiler environments. If it is necessary to add a dependency(download and build it) for this library? Jenkins has passed, is jenkins machines have installed this library? http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/util/hbw_cache.cc File src/kudu/util/hbw_cache.cc: http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/util/hbw_cache.cc@13 PS16, Line 13: wtih nit: with -- To view, visit http://gerrit.cloudera.org:8080/19764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164 Gerrit-Change-Number: 19764 Gerrit-PatchSet: 16 Gerrit-Owner: Sammy Nah <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 07:04:52 +0000 Gerrit-HasComments: Yes
