Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19779 )

Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc@424
PS3, Line 424:
             : . Install `gcc8` and `gcc8-c++` (might require activating 
Development Tools
             : Module to add corresponding package repositories):
             : +
             : ----
             : $ sudo zypper install gcc8 gcc8-c++
             : ----
             :
             : . NOTE: If building on SLES 15, the system compiler (GCC7) may 
be used
             : instead:
             : +
             : ----
             : $ sudo zypper install gcc7 gcc7-c++
             : ----
> I am conflused about the gcc version.
Yes, using GCC8 is a common method -- GCC8 can be used to build Kudu on both 
SLES versions (I guess at this time we are talking about SLES12 and SLES15).

What this doc is trying to say is that on SLES15 people can use GCC7 to build 
Kudu since GCC7 is a system compiler, so they don't need to enable/activate 
extra features and add extra package repositories (that would be the case if 
installing GCC8).  Historically (i.e. starting SLES12), the recommended 
compiler on SLES for Kudu was GCC8, but since SLES15 now has C++17-capable 
system compiler, it can be used to compile Kudu.

Does it bring any clarity now?

Let me know what can be done to make this less confusing.  Thanks!



--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Tue, 25 Apr 2023 18:18:49 +0000
Gerrit-HasComments: Yes

Reply via email to