Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Allow creating tablets under replicated tables ...................................................................... Patch Set 16: (10 comments) http://gerrit.cloudera.org:8080/#/c/19571/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19571/15//COMMIT_MSG@7 PS15, Line 7: under > What does "enough" mean, does 1 out of RF = 3 is enough? How about to descr Done http://gerrit.cloudera.org:8080/#/c/19571/15//COMMIT_MSG@10 PS15, Line 10: less t > Same. Done http://gerrit.cloudera.org:8080/#/c/19571/15/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/15/src/kudu/tools/kudu-tool-test.cc@9205 PS15, Line 9205: opts.extra_master_flags = { > nit: they can be simplified by: Done http://gerrit.cloudera.org:8080/#/c/19571/15/src/kudu/tools/kudu-tool-test.cc@9237 PS15, Line 9237: Status s = create_table_func(kOverRegistedTSTableName, 6); > nit: because many place would return InvalidArgument, so also check the err Done http://gerrit.cloudera.org:8080/#/c/19571/15/src/kudu/tools/kudu-tool-test.cc@9239 PS15, Line 9239: ASSERT_STR_CONTAINS(s.ToString(), "not enough registered tablet servers to"); > How about use client to OpenTable and then check the return status is NotFo Done http://gerrit.cloudera.org:8080/#/c/19571/15/src/kudu/tools/kudu-tool-test.cc@9244 PS15, Line 9244: > Why check ksck? No need. Remove it. http://gerrit.cloudera.org:8080/#/c/19571/15/src/kudu/tools/kudu-tool-test.cc@9277 PS15, Line 9277: // Wait the restarted tablet server to send a heartbeat and be registered in catalog manaager. > Same, check the error meesage contains some key words. Done http://gerrit.cloudera.org:8080/#/c/19571/15/src/kudu/tools/kudu-tool-test.cc@9309 PS15, Line 9309: } else { > The TestWorkload will start write threads to write data into the table, I d Done http://gerrit.cloudera.org:8080/#/c/19571/15/src/kudu/tools/kudu-tool-test.cc@9312 PS15, Line 9312: > Is inserting data necessary? If the table status is health, it's not needed Done http://gerrit.cloudera.org:8080/#/c/19571/15/src/kudu/tools/kudu-tool-test.cc@9338 PS15, Line 9338: } > If moving the test to client-test.cc, you are able to access the master sta InternalMiniCluster can not set flags like --catalog_manager_check_ts_count_for_create_table=false. -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 16 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 06 May 2023 09:57:01 +0000 Gerrit-HasComments: Yes
