Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )
Change subject: KUDU-1945 Update docs with non-unique PK ...................................................................... Patch Set 2: (13 comments) > Patch Set 2: > > https://kudu.apache.org/faq.html#does-kudu-have-relational-features-like-autoincrement-column-pkfk-constraints-or-built-in-indexes > > Also needs to be updated. > > We need to put a note about restoring tables as well with auto incrementing > column - it is not currently supported. I will create a separate patch to update the faq.md as that file lives not on kudu/master rather kudu/gh-pages. http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc File docs/schema_design.adoc: http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@237 PS2, Line 237: an > nit: a Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@240 PS2, Line 240: key > nit: keys Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@241 PS2, Line 241: key > nit: keys Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@263 PS2, Line 263: uqnique > nit: unique Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@265 PS2, Line 265: key > add a comma after key Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@268 PS2, Line 268: counter > counter which is used to assign value for auto-incrementing column Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@275 PS2, Line 275: incrementin > nit: incrementing Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@275 PS2, Line 275: may > can Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@277 PS2, Line 277: During inserts one has to speciy the non-unique primary key columns and the auto-incrementing : counter is populated on the server side. > For inserts, one has to provide values for the non-unique primary key colum Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@282 PS2, Line 282: > please mention upsert operation is not supported for table with non-unique Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@283 PS2, Line 283: uqnique > nit: unique Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@285 PS2, Line 285: insert > insertion for auto-incrementing column. Done http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@288 PS2, Line 288: : > add space after : This is adoc syntax to create link. Can't add space, as that doesn't renders the link properly. https://docs.asciidoctor.org/asciidoc/latest/macros/link-macro/ -- To view, visit http://gerrit.cloudera.org:8080/19809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31 Gerrit-Change-Number: 19809 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 08 May 2023 16:17:42 +0000 Gerrit-HasComments: Yes
