Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Allow creating tablets under replicated tables ...................................................................... Patch Set 23: (1 comment) http://gerrit.cloudera.org:8080/#/c/19571/23/src/kudu/integration-tests/create-table-itest.cc File src/kudu/integration-tests/create-table-itest.cc: http://gerrit.cloudera.org:8080/#/c/19571/23/src/kudu/integration-tests/create-table-itest.cc@703 PS23, Line 703: { : // Restart the first tablet server. : NO_FATALS(cluster_->tablet_server(0)->Restart()); : // Wait the restarted tablet server to send a heartbeat and be registered in catalog manaager. : SleepFor(MonoDelta::FromMilliseconds(kHeartbeatIntervalMs)); : } : : // Create a table with RF=5. It should succeed. : ASSERT_OK(create_table_func(kFiveReplicaTableName, 5)); > What about using 'cluster_.WaitForTabletServerCount'? Maybe in some cases s WaitForTabletServerCount() will get all registered tablet servers, not the available registered tablet servers. I can not find a better way to make sure the restarted tablet server has been registered an available tablet server. -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 23 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 15 May 2023 08:26:59 +0000 Gerrit-HasComments: Yes
