Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 )
Change subject: KUDU-3413 [multi-tenancy] update server key for multi-tenancy ...................................................................... Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19622/9/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/19622/9/src/kudu/util/env_posix.cc@210 PS9, Line 210: DEFINE_validator(encryption_key_length, > Well, we need to use the flag for KuduTest::GetEncryptionKey() in test_util Does it matter? You can DECLARE_bool(enable_multi_tenancy) anywhere after defining it, gflags are global. http://gerrit.cloudera.org:8080/#/c/19622/10/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/19622/10/src/kudu/util/test_util.cc@93 PS10, Line 93: static const char* const kEncryptionTenantName = "default_tenant_kudu"; : static const char* const kEncryptionTenantID = "00000000000000000000000000000000"; Can we reuse the variables in https://gerrit.cloudera.org/c/19622/10/src/kudu/fs/dir_manager.h#56? -- To view, visit http://gerrit.cloudera.org:8080/19622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e450d73940eb1dbaac6f905a46d6ccd084f15cf Gerrit-Change-Number: 19622 Gerrit-PatchSet: 10 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 15 May 2023 15:23:43 +0000 Gerrit-HasComments: Yes
