Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19613 )
Change subject: Exit external_mini_cluster services when test is stopped ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19613/2/src/kudu/master/master_runner.cc File src/kudu/master/master_runner.cc: http://gerrit.cloudera.org:8080/#/c/19613/2/src/kudu/master/master_runner.cc@467 PS2, Line 467: while (true) { : SleepFor(MonoDelta::FromSeconds(1)); : if (FLAGS_exit_if_orphaned && getppid() == 1) return Status::OK(); : } > Ah, maybe your concern was about running 'kudu master/tserver run' in Docke The change could work, but we still need to introduce the new flag. Externel mini clusters are started with 'kudu master/tserver run', that's why external_mini_cluster.cc creates a list of flags to use with these commands. The idea is that maybe somebody is running "kudu master run " in a script in the background and the caller script exits. In this case the change would break the behaviour and there is no way to decide if it was intentional or not, so that's why the flag was introduced. -- To view, visit http://gerrit.cloudera.org:8080/19613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ca88b3b8924dc7dc5c05a0239dfa86db67af255 Gerrit-Change-Number: 19613 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai <aba...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Mon, 15 May 2023 15:58:52 +0000 Gerrit-HasComments: Yes
