Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19896 )
Change subject: [rpc] tighten TLS cert requirements for JWT authn ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19896/5/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/19896/5/python/kudu/tests/test_client.py@899 PS5, Line 899: @unittest.skip("needs Kudu IPKI CA cert to be in the client's cert bundle") > is this going to be re-enabled in a later patch? Yes: http://gerrit.cloudera.org:8080/19913 http://gerrit.cloudera.org:8080/#/c/19896/5/src/kudu/rpc/negotiation-test.cc File src/kudu/rpc/negotiation-test.cc: http://gerrit.cloudera.org:8080/#/c/19896/5/src/kudu/rpc/negotiation-test.cc@1132 PS5, Line 1132: > nit: extra line This line provides an extra separation between the Status::NotAuthorized() above with the comment and the Status::NetworkError() which comes with no comment. -- To view, visit http://gerrit.cloudera.org:8080/19896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2b45227cc4d827b8fab2d9517c09b62135fd757 Gerrit-Change-Number: 19896 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 22 May 2023 20:28:43 +0000 Gerrit-HasComments: Yes
