Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19935 )
Change subject: [cmake] Kudu should compile on Mac OS without SDKROOT set. ...................................................................... [cmake] Kudu should compile on Mac OS without SDKROOT set. Cmake figures out the sdkroot path perfectly without the environment variable SDKROOT. The only thing that fails is the linker test in cmake_modules/KuduLinker.cmake. Setting SDKROOT is also missing from the docs/installation.adoc, although it is mandatory (it should not). Change-Id: I1cfe84f31238ccb208bdf49e8b05688107dd5ae2 Reviewed-on: http://gerrit.cloudera.org:8080/19935 Tested-by: Kudu Jenkins Reviewed-by: Attila Bukor <[email protected]> Tested-by: Attila Bukor <[email protected]> --- M cmake_modules/KuduLinker.cmake 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Attila Bukor: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1cfe84f31238ccb208bdf49e8b05688107dd5ae2 Gerrit-Change-Number: 19935 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
