Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19922 )
Change subject: [client] fix API non-compliance in KuduUpsertIgnore ...................................................................... [client] fix API non-compliance in KuduUpsertIgnore Kudu C++ client API is still assumed to be C++98 compatible. That's an invariant that has been in place in the very beginning of 1.x version history, so it should be kept as-is unless changing the major version. Prior to this patch, client_examples-test.sh would fail while checking a standalone compilation of kudu/client/write_op.h This is a follow-up to ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0. Change-Id: I83f4e65bc3811ac701f5908beb480b39ad413641 Reviewed-on: http://gerrit.cloudera.org:8080/19765 Reviewed-by: Abhishek Chennaka <[email protected]> Tested-by: Alexey Serbin <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/19922 Tested-by: Kudu Jenkins Reviewed-by: Yingchun Lai <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/client/write_op.h 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Yingchun Lai: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: I83f4e65bc3811ac701f5908beb480b39ad413641 Gerrit-Change-Number: 19922 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]>
