Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19794 )
Change subject: [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/19794/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19794/11//COMMIT_MSG@16 PS11, Line 16: one using java client nit: the one used by java client http://gerrit.cloudera.org:8080/#/c/19794/11/src/kudu/common/partition_pruner-test.cc File src/kudu/common/partition_pruner-test.cc: http://gerrit.cloudera.org:8080/#/c/19794/11/src/kudu/common/partition_pruner-test.cc@1081 PS11, Line 1081: temp_values.push_back(t_value); : test_case.push_back(reinterpret_cast<const void*>(&temp_values[temp_values.size() - 1])); Can this be simplified to 'test_case.push_back(reinterpret_cast<const void*>(&t_value))' ? http://gerrit.cloudera.org:8080/#/c/19794/11/src/kudu/common/partition_pruner-test.cc@1091 PS11, Line 1091: for (int i = 0; i < kKeyColumnSize; i++) { : predicates.emplace_back(ColumnPredicate::InList(schema.column(i), &test_cases[i])); : } Maybe this can be moved to the for loop at L1079? And then the 'test_cases' can be removed too. http://gerrit.cloudera.org:8080/#/c/19794/11/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/19794/11/src/kudu/common/partition_pruner.cc@224 PS11, Line 224: return; nit: Need to document this short circuit condition. -- To view, visit http://gerrit.cloudera.org:8080/19794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4bea5c10b4ac2c62b85625fe9d2a33ceb4fb2e9 Gerrit-Change-Number: 19794 Gerrit-PatchSet: 11 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 30 May 2023 11:59:48 +0000 Gerrit-HasComments: Yes
