Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19873 )
Change subject: KUDU-3448 Move password retrieval to master init ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19873/3/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/19873/3/src/kudu/master/catalog_manager.h@1400 PS3, Line 1400: // Password for the encrypted IPKI and TSK private keys stored in the : // sys-catalog table. : std::string ipki_private_key_password_; : std::string tsk_private_key_password_; > I thought about this, but I don't think it's a very good idea. It is possib Yep, that makes sense to me. http://gerrit.cloudera.org:8080/#/c/19873/4/src/kudu/security/token_signing_key.h File src/kudu/security/token_signing_key.h: http://gerrit.cloudera.org:8080/#/c/19873/4/src/kudu/security/token_signing_key.h@72 PS4, Line 72: const std::string& password, Consider making this the last parameters, the same as in the other constructor for TokenSigningPrivateKey. Also, having it as parameter by default set to an empty string could be helpful to reduce updates in non-relevant tests. -- To view, visit http://gerrit.cloudera.org:8080/19873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I746e657ae8d295f5f34225d63686beea1dff6b7c Gerrit-Change-Number: 19873 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 30 May 2023 18:22:08 +0000 Gerrit-HasComments: Yes
