Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19958 )
Change subject: [client] add -Werror flag for checking client C++ API ...................................................................... [client] add -Werror flag for checking client C++ API I noticed that many contemporary C++ compilers didn't error out but issued a warning instead when compiling a code with C++11 features, even if running with -std=c++98 flag. To make the API compatibility check more robust, this patch adds -Werror flag to make sure the client_examples-test.sh fails if incompatibility is introduced into corresponding header files. This is a follow-up to 10b1c30441dd48bebf692db8a41464cf08319908. Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3 Reviewed-on: http://gerrit.cloudera.org:8080/19784 Reviewed-by: Abhishek Chennaka <[email protected]> Tested-by: Alexey Serbin <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/19958 Reviewed-by: Yingchun Lai <[email protected]> Tested-by: Yingchun Lai <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> --- M src/kudu/client/client_examples-test.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yingchun Lai: Looks good to me, but someone else must approve; Verified Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3 Gerrit-Change-Number: 19958 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]>
