Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19978 )
Change subject: [thirdparty] handle OpenSSL errors properly in curl and squeasel ...................................................................... [thirdparty] handle OpenSSL errors properly in curl and squeasel This patch improves handling of OpenSSL errors in squeasel and curl, making the code more robust. This patch addresses the flakiness in the newly added JWT tests that were failing in DEBUG-enabled builds because of the assertions triggered by the SCOPED_OPENSSL_NO_PENDING_ERRORS macro. I'm planning to submit the patches to the CURL project upstream and post a PR to the squeasel repo [1] correspondingly. To expedite the fix and avoid too many unrelated test failures for every CR submitted to the upstream gerrit, it makes sense to just patch the current source of these two thirdparty components as an interim solution. [1] https://github.com/cloudera/squeasel Change-Id: I209ceb35ded66222c90b82e98e7d191f33573217 Reviewed-on: http://gerrit.cloudera.org:8080/19849 Tested-by: Kudu Jenkins Reviewed-by: Zoltan Chovan <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> (cherry picked from commit cc646190d3a16bf4f22ac9c32253cf7d4ad05cca) Reviewed-on: http://gerrit.cloudera.org:8080/19978 Reviewed-by: Yingchun Lai <[email protected]> --- M thirdparty/download-thirdparty.sh A thirdparty/patches/curl-handle-openssl-errors.patch A thirdparty/patches/squeasel-handle-openssl-errors.patch 3 files changed, 320 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Yingchun Lai: Looks good to me, approved Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: I209ceb35ded66222c90b82e98e7d191f33573217 Gerrit-Change-Number: 19978 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
